[5.1] Add toolbar buttons in language installation toolbar #42610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add toolbar button link to manage languages * add toolbar button link content languages * remove set title for toolbar - is already handled in the parent::addToolbar * remove set title for toolbar - is already handled in the parent::addToolbar * remove duplicate access request - is already handled in parent::addToolbar * add language strings for toolbar buttons
Quy
reviewed
Jan 4, 2024
* change order of language strings Co-authored-by: Quy <[email protected]>
brianteeman
reviewed
Jan 4, 2024
|
Nothing against this PR but I don't see how it resolves #35268 |
|
I have tested this item ✅ successfully on a76ae69 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42610. |
|
I have tested this item ✅ successfully on 46cd2fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42610. |
|
I have tested this item ✅ successfully on 46cd2fc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42610. |
a little step in the right direction |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42610. |
|
Thanks ;) |
4 tasks
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Feb 24, 2024
joomla/joomla-cms#42220 - (только для en-GB) joomla/joomla-cms#37320 + joomla/joomla-cms#42390 + joomla/joomla-cms#42393 + joomla/joomla-cms#42584 + joomla/joomla-cms#42607 + joomla/joomla-cms#42402 + joomla/joomla-cms#42334 + joomla/joomla-cms#42610 + joomla/joomla-cms#42663 + joomla/joomla-cms#42747 +
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #35268 .
Summary of Changes
Added toolbar buttons to the language installation view to go directly to the language manage view or the content language view - just like in the extension installation view.
Testing Instructions
Go to System => Install => Languages
Actual result BEFORE applying this Pull Request
No toolbar buttons for manage languages and content languages
Expected result AFTER applying this Pull Request
A new toolbar button to go directly to manage languages and to content languages
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed